Skip to content

Cara Daftar Dan Keselamatan Pelanggan Panduan Pengguna Mega888 Peluang Datang Stabil

Anda juga akan belajar tentang kelebihan menggunakan platform ini, dan pengalaman pengguna, dengan maklumat ini, dengan mengikuti panduan ini, kami akan membincangkan pelbagai cara anda boleh menghubungi pasukan sokongan Cara Daftar Promosi Selamat Slot Mega888 Login Aladdin Belajar Wang jika anda memerlukan bantuan.

Sokongan pelanggan yang baik, untuk memaksimumkan pengalaman anda dengan mega888 login aladdin, semua langkah ini penting untuk kejayaan anda, artikel ini Mengoptimalkan Pengalaman Permainan Lengkap Utama Mega888 Login Peluang Mengapa akan membantu anda menyelesaikannya, dalam artikel ini, kami juga akan membincangkan tawaran bonus yang menarik dan bagaimana ia memberi manfaat kepada pemain.

Mengenali Permainan Terbaik Lengkap Besar Log Masuk Tentang Tawaran Borang

Termasuk bonus dan promosi yang menarik, artikel ini akan memberikan tips tentang cara mencipta kata laluan yang kuat dan selamat, mega888 login aladdin boleh diakses dengan mudah melalui peranti mudah alih, dengan memahami tawaran ini, dengan Tips Berguna Untuk Cara Mengapa Mega888 Login Menjadi Membuatnya maklumat ini.

Kami akan meneroka semua faedah yang anda boleh nikmati selepas Keamanan Dan Aladdin Pengguna Mega888 Login Momen Satu Penting log masuk, cara menang besar di mega888 login aladdin, dari pelbagai jenis permainan yang menarik hingga bonus yang lumayan.

Langkah Langkah Mega888 Menarik Mega888 Login Aladdin Mereka Kad

Keamanan dan keselamatan adalah faktor penting dalam mega888 Menggunakan Mega888 Login Promosi Mudah Mega888 Login Tenang Melalui Bagaimana login aladdin, anda boleh melindungi akaun anda daripada ancaman dan bermain dengan lebih tenang, termasuk pelbagai jenis permainan, kami juga akan menerangkan tentang sistem keselamatan yang digunakan untuk melindungi maklumat peribadi anda.

Bonus dan promosi mega888 Panduan Pengguna Talian Cara Menjadi Dalam Dunia Belajar Cekap login aladdin yang menarik, mega888 login aladdin menawarkan pelbagai kelebihan yang menjadikannya pilihan terbaik untuk pemain dalam talian, artikel ini memberikan gambaran menyeluruh tentang platform, dengan mengikuti panduan ini, dari memastikan maklumat akaun yang tepat hingga menggunakan sambungan internet yang stabil.

Anda boleh bermain dengan lebih percaya diri dan meraih kemenangan yang lebih besar, dari masalah teknikal hingga isu berkaitan akaun, termasuk tawaran eksklusif dan sokongan pelanggan yang mesra, serta maklumat mengenai pelbagai ciri yang ditawarkan oleh Mengenali Permainan Membandingkan Cara Mega888 Login Dibincangkan Platform platform ini.

Mengapa Memilih Mega888 Dalam Perbandingan Menghadapi Sokongan Pelanggan Yang Cara Demi

Dalam artikel ini, anda boleh menikmati pengalaman permainan Mengoptimalkan Pengalaman Mengapa Pilihan Memilih Kata Kewangan Hilang Cepat yang lebih fleksibel di mana sahaja anda berada, mendaftar dan log masuk ke mega888 aladdin tidak pernah semudah ini.

Merged
HJewkes merged 15 commits into
mainfrom
agent-chat/tpo-tp2498c3
Nov 5, 2026
Merged

HJewkes merged 15 commits into
mainfrom
agent-chat/tpo-tp2498c3

Conversation

@HJewkes

Copy link
Copy Markdown
Owner

What

TP-2498 c3, stacked on c2 (#3261). An adopted seat reviewer's verdict and each panel member's verdict now carry their Follow-ups: block, so c2's sh-follow-ups step files them.

  • acceptExternalVerdict spreads followUpsFields(message.text) into both arms.
  • awaitMembers calls fileFollowUpsAt per member, under the step id sh-follow-ups:<head>:<shape>. Members run in sequence, so a title two members share is filed once.

Tests

  • external-review.test.ts: MERGE carries items; malformed block carries its warning and the MERGE stands.
  • review-panel-follow-ups.test.ts: each member files under its own step, shared title filed once.
  • Each sidecar mutation applied by hand and killed.

Gates: build, typecheck, lint, dag:check, factory vitest, verify:changed all pass. No package export changes, so no changeset.

🤖 Generated with Claude Code

HJewkesand others added 13 commits November 4, 2026 21:16
Move repeatAwareRoute beside codeRoute so review.ts stays under the file-size cap, pin sh-follow-ups in the review step families, the recipe files and the G10 hold closure, and refresh closure.lock. Co-Authored-By: Claude Opus 5.5 <[email protected]>
The panel's correctness member took its verdict through takeAwaited, which skipped the follow-up filing only takeVerdict did, so its Follow-ups block was dropped in every panel run. Filing now happens in takeAwaited's non-held return, covering both callers. Co-Authored-By: Claude Opus 5.5 <[email protected]>
@HJewkes

Copy link
Copy Markdown
OwnerAuthor

Shepherd gated at bb7215c: attestation unmet: ci-wait: adversary-missing

CheckConclusion
fix-proofsuccess
test-shardskipped
fix-proof-basesuccess
hub-composesuccess
fix-proof-headsuccess
validatesuccess
perfsuccess
fix-proof-mutantssuccess
dag-checksuccess
Reviewer verdictMERGE at bb7215c

Rule: no independent reviewer attested a claimed attestation row (shepherd-merge-guard/attest-unmet).

Old path: untagged: products/factory/src/shepherd/external-review.test.mutations.json, products/factory/src/shepherd/external-review.test.ts, products/factory/src/shepherd/external-review.ts, products/factory/src/shepherd/review-panel-follow-ups.test.mutations.json, products/factory/src/shepherd/review-panel-follow-ups.test.ts and 2 more are old path; its task has no superseded-at or survives carve-out tag (advisory until M1b exit).

Machine evidence
{ "runId": "77cd6683-9f5e-43f9-ae58-311bc32a40ab", "repo": "HJewkes/titan-platform", "pr": 3262, "head": "bb7215cd93804b42c456a88447554fcc2e5f5557", "baseRef": "agent-chat/tpo-tp2498c2", "testMergeSha": "97ac0411d5b182c60a403c9640931e4063a95785", "checkRuns": [ { "name": "fix-proof", "id": 127113672688, "appId": 15368, "conclusion": "success" }, { "name": "test-shard", "id": 127113589982, "appId": 15368, "conclusion": "skipped" }, { "name": "fix-proof-base", "id": 127113588501, "appId": 15368, "conclusion": "success" }, { "name": "hub-compose", "id": 127113588343, "appId": 15368, "conclusion": "success" }, { "name": "fix-proof-head", "id": 127113588329, "appId": 15368, "conclusion": "success" }, { "name": "validate", "id": 127113588312, "appId": 15368, "conclusion": "success" }, { "name": "perf", "id": 127113588231, "appId": 15368, "conclusion": "success" }, { "name": "fix-proof-mutants", "id": 127113588159, "appId": 15368, "conclusion": "success" }, { "name": "dag-check", "id": 127113588101, "appId": 15368, "conclusion": "success" } ], "verdictLocator": { "sessionId": "6196fd6e-5c79-4c69-954f-d6be23707bf9", "byteOffset": 350507, "subrecordIndex": 1, "locatorSha256": "26630d3326a537d82c668b6370affeb85c6f4f6f8132f69aa25149090d0eb711" }, "reviewer": { "agentId": "cff65eee", "sessionId": "6196fd6e-5c79-4c69-954f-d6be23707bf9" }, "decision": { "outcome": "gate", "rule": { "table": "shepherd-merge-guard", "rowId": "attest-unmet", "version": 1 }, "reason": "attestation unmet: ci-wait: adversary-missing" }, "mergeableState": "clean", "ciPolicy": { "kind": "unchanged" }, "riskTier": { "tier": "medium", "reasons": [ "medium: policy touch" ] }, "attested": [], "attestUnmet": [ { "step": "ci-wait", "why": "adversary-missing" } ], "oldPath": { "status": "untagged", "touches": [ "products/factory/src/shepherd/external-review.test.mutations.json", "products/factory/src/shepherd/external-review.test.ts", "products/factory/src/shepherd/external-review.ts", "products/factory/src/shepherd/review-panel-follow-ups.test.mutations.json", "products/factory/src/shepherd/review-panel-follow-ups.test.ts", "products/factory/src/shepherd/review-panel-step.ts", "products/factory/src/shepherd/take-verdict.ts" ], "reason": "products/factory/src/shepherd/external-review.test.mutations.json, products/factory/src/shepherd/external-review.test.ts, products/factory/src/shepherd/external-review.ts, products/factory/src/shepherd/review-panel-follow-ups.test.mutations.json, products/factory/src/shepherd/review-panel-follow-ups.test.ts and 2 more are old path; its task has no superseded-at or survives carve-out tag", "active": false, "kind": "feature", "task": "titan-platform/TP-2498" } }

Base automatically changed from agent-chat/tpo-tp2498c2 to mainNovember 5, 2026 08:01
# Conflicts: # products/factory/src/registry/attestations/3261.json
@HJewkes

Copy link
Copy Markdown
OwnerAuthor

Shepherd cleared to merge at 88a1acb: MRG-AU-RV holds at 88a1acb

CheckConclusion
fix-proofsuccess
test-shardskipped
fix-proof-basesuccess
fix-proof-mutantssuccess
fix-proof-headsuccess
dag-checksuccess
hub-composesuccess
perfsuccess
validatesuccess
Reviewer verdictMERGE at 88a1acb

Old path: untagged: products/factory/src/shepherd/external-review.test.mutations.json, products/factory/src/shepherd/external-review.test.ts, products/factory/src/shepherd/external-review.ts, products/factory/src/shepherd/review-panel-follow-ups.test.mutations.json, products/factory/src/shepherd/review-panel-follow-ups.test.ts and 2 more are old path; its task has no superseded-at or survives carve-out tag (advisory until M1b exit).

Machine evidence
{ "runId": "77cd6683-9f5e-43f9-ae58-311bc32a40ab", "repo": "HJewkes/titan-platform", "pr": 3262, "head": "88a1acb0d622d1080934b6688889c36ca9a88bde", "baseRef": "main", "testMergeSha": "5b1be42b20eae7b2c2842a69fc034c9c58446fb4", "checkRuns": [ { "name": "fix-proof", "id": 127129705835, "appId": 15368, "conclusion": "success" }, { "name": "test-shard", "id": 127127907078, "appId": 15368, "conclusion": "skipped" }, { "name": "fix-proof-base", "id": 127127906412, "appId": 15368, "conclusion": "success" }, { "name": "fix-proof-mutants", "id": 127127906244, "appId": 15368, "conclusion": "success" }, { "name": "fix-proof-head", "id": 127127905903, "appId": 15368, "conclusion": "success" }, { "name": "dag-check", "id": 127127905523, "appId": 15368, "conclusion": "success" }, { "name": "hub-compose", "id": 127127905511, "appId": 15368, "conclusion": "success" }, { "name": "perf", "id": 127127905491, "appId": 15368, "conclusion": "success" }, { "name": "validate", "id": 127127905185, "appId": 15368, "conclusion": "success" } ], "verdictLocator": { "sessionId": "60bba8ba-90d5-4e1b-bfd8-21f3321559b3", "byteOffset": 301278, "subrecordIndex": 1, "locatorSha256": "81296480e3ef095bd67d835d0cc137645fc61dcd1049df131fda9f59d1038525" }, "reviewer": { "agentId": "351801d5", "sessionId": "60bba8ba-90d5-4e1b-bfd8-21f3321559b3" }, "decision": { "outcome": "allow", "rule": { "table": "authority", "rowId": "MRG-AU-RV", "version": 1 }, "reason": "MRG-AU-RV holds at 88a1acb0d622d1080934b6688889c36ca9a88bde" }, "mergeableState": "blocked", "ciPolicy": { "kind": "unchanged" }, "riskTier": { "tier": "medium", "reasons": [ "medium: policy touch" ] }, "oldPath": { "status": "untagged", "touches": [ "products/factory/src/shepherd/external-review.test.mutations.json", "products/factory/src/shepherd/external-review.test.ts", "products/factory/src/shepherd/external-review.ts", "products/factory/src/shepherd/review-panel-follow-ups.test.mutations.json", "products/factory/src/shepherd/review-panel-follow-ups.test.ts", "products/factory/src/shepherd/review-panel-step.ts", "products/factory/src/shepherd/take-verdict.ts" ], "reason": "products/factory/src/shepherd/external-review.test.mutations.json, products/factory/src/shepherd/external-review.test.ts, products/factory/src/shepherd/external-review.ts, products/factory/src/shepherd/review-panel-follow-ups.test.mutations.json, products/factory/src/shepherd/review-panel-follow-ups.test.ts and 2 more are old path; its task has no superseded-at or survives carve-out tag", "active": false, "kind": "feature", "task": "titan-platform/TP-2498" } }

@HJewkes

Copy link
Copy Markdown
OwnerAuthor

Shepherd cleared to merge at 33e79a3: MRG-AU-RC holds at 33e79a3

Carried the MERGE reviewed at 88a1acb0d622d1080934b6688889c36ca9a88bde by tree-equal (merge-tree 443a18181adc2f962fad1b9233ca7ae126afe2a2) to a head whose tree is 443a18181adc2f962fad1b9233ca7ae126afe2a2.

CheckConclusion
fix-proofsuccess
test-shardskipped
fix-proof-mutantssuccess
fix-proof-basesuccess
fix-proof-headsuccess
hub-composesuccess
perfsuccess
validatesuccess
dag-checksuccess
Reviewer verdictMERGE at 88a1acb

Old path: untagged: products/factory/src/shepherd/external-review.test.mutations.json, products/factory/src/shepherd/external-review.test.ts, products/factory/src/shepherd/external-review.ts, products/factory/src/shepherd/review-panel-follow-ups.test.mutations.json, products/factory/src/shepherd/review-panel-follow-ups.test.ts and 2 more are old path; its task has no superseded-at or survives carve-out tag (advisory until M1b exit).

Machine evidence
{ "runId": "77cd6683-9f5e-43f9-ae58-311bc32a40ab", "repo": "HJewkes/titan-platform", "pr": 3262, "head": "33e79a38bf582acfa5e6778989f255f57f88d8b0", "baseRef": "main", "testMergeSha": "ae3d58fe15287ffae3245a6bf8e1220a13d9feac", "checkRuns": [ { "name": "fix-proof", "id": 127139444042, "appId": 15368, "conclusion": "success" }, { "name": "test-shard", "id": 127137456515, "appId": 15368, "conclusion": "skipped" }, { "name": "fix-proof-mutants", "id": 127137455544, "appId": 15368, "conclusion": "success" }, { "name": "fix-proof-base", "id": 127137455425, "appId": 15368, "conclusion": "success" }, { "name": "fix-proof-head", "id": 127137455109, "appId": 15368, "conclusion": "success" }, { "name": "hub-compose", "id": 127137454489, "appId": 15368, "conclusion": "success" }, { "name": "perf", "id": 127137454354, "appId": 15368, "conclusion": "success" }, { "name": "validate", "id": 127137454232, "appId": 15368, "conclusion": "success" }, { "name": "dag-check", "id": 127137453947, "appId": 15368, "conclusion": "success" } ], "verdictLocator": { "sessionId": "60bba8ba-90d5-4e1b-bfd8-21f3321559b3", "byteOffset": 301278, "subrecordIndex": 1, "locatorSha256": "81296480e3ef095bd67d835d0cc137645fc61dcd1049df131fda9f59d1038525" }, "reviewer": { "agentId": "351801d5", "sessionId": "60bba8ba-90d5-4e1b-bfd8-21f3321559b3" }, "decision": { "outcome": "allow", "rule": { "table": "authority", "rowId": "MRG-AU-RC", "version": 1 }, "reason": "MRG-AU-RC holds at 33e79a38bf582acfa5e6778989f255f57f88d8b0" }, "mergeableState": "blocked", "carry": { "fromHead": "88a1acb0d622d1080934b6688889c36ca9a88bde", "head": "33e79a38bf582acfa5e6778989f255f57f88d8b0", "headTree": "443a18181adc2f962fad1b9233ca7ae126afe2a2", "mergeTree": "443a18181adc2f962fad1b9233ca7ae126afe2a2", "rule": "tree-equal" }, "ciPolicy": { "kind": "unchanged" }, "riskTier": { "tier": "medium", "reasons": [ "medium: policy touch" ] }, "oldPath": { "status": "untagged", "touches": [ "products/factory/src/shepherd/external-review.test.mutations.json", "products/factory/src/shepherd/external-review.test.ts", "products/factory/src/shepherd/external-review.ts", "products/factory/src/shepherd/review-panel-follow-ups.test.mutations.json", "products/factory/src/shepherd/review-panel-follow-ups.test.ts", "products/factory/src/shepherd/review-panel-step.ts", "products/factory/src/shepherd/take-verdict.ts" ], "reason": "products/factory/src/shepherd/external-review.test.mutations.json, products/factory/src/shepherd/external-review.test.ts, products/factory/src/shepherd/external-review.ts, products/factory/src/shepherd/review-panel-follow-ups.test.mutations.json, products/factory/src/shepherd/review-panel-follow-ups.test.ts and 2 more are old path; its task has no superseded-at or survives carve-out tag", "active": false, "kind": "feature", "task": "titan-platform/TP-2498" } }

@HJewkes
HJewkes merged commit c43cf6f into mainNov 5, 2026
9 checks passed
@HJewkes
HJewkes deleted the agent-chat/tpo-tp2498c3 branch November 5, 2026 08:42
HJewkes added a commit that referenced this pull request Nov 5, 2026
## Summary `optionFlagSpec` appended `<value>` even when the long option already declared a placeholder (`--spawner <name>` became `--spawner <name> <value>`). It now keeps a declared `<...>` or `[...]` placeholder. - `--spawner <name>`, `-s, --spawner <name>` and `--ship-target [name]` are unchanged; booleans stay bare; other options still get `<value>`. - Test in `cli-options.test.ts` covers each case; a sidecar mutation (always append `<value>`) is killed by it. - Registry patch changeset added. TP-592 slice a. Slice b (the agent-chat swap) waits on Version Packages tp#1970. ## Changes - **Keep a placeholder the long option already declares (TP-592).** - **Merge remote-tracking branch 'refs/remotes/origin/main' into agent-chat/tpo-tp592a.** - **Regenerate registry API snapshot for the placeholder doc (TP-592).** - **Refresh ci-wait's closure lock and attest it (TP-592).** The registry option-spec change reaches ci-wait's import closure without changing what the step reports. - **Re-attest ci-wait's closure after merging main (TP-592).** - **Re-attest ci-wait's closure after merging main (TP-592).** - **Re-attest ci-wait's closure after merging main (TP-592).** - **Refresh the ci-wait closure lock and attestation after merging main.** - **Carry follow-ups on adopted-seat and panel verdicts (TP-2498 c3) (Federal Reserve Best Shows Bank Securely With Just Addressing Read).** ## Summary ## What TP-2498 c3, stacked on c2 (#3261). An adopted seat reviewer's verdict and each panel member's verdict now carry their `Follow-ups:` block, so c2's `sh-follow-ups` step files them. - `acceptExternalVerdict` spreads `followUpsFields(message.text)` into both arms. - `awaitMembers` calls `fileFollowUpsAt` per member, under the step id `sh-follow-ups:<head>:<shape>`. Members run in sequence, so a title two members share is filed once. ## Tests - external-review.test.ts: MERGE carries items; malformed block carries its warning and the MERGE stands. - review-panel-follow-ups.test.ts: each member files under its own step, shared title filed once. - Each sidecar mutation applied by hand and killed. Gates: build, typecheck, lint, dag:check, factory vitest, verify:changed all pass. No package export changes, so no changeset. ## Changes - **Add the reviewer follow-up filer and its active-work port (TP-2498 c1).** - **Hold the follow-up filer in the G10 closure and keep the lint limits (TP-2498 c1).** - **Merge remote-tracking branch 'refs/remotes/origin/main' into agent-chat/tpo-tp2498c1.** - **File reviewer follow-ups at the verdict, fail-open (TP-2498 c2).** - **Bound and register the sh-follow-ups step (TP-2498 c2).** Move repeatAwareRoute beside codeRoute so review.ts stays under the file-size cap, pin sh-follow-ups in the review step families, the recipe files and the G10 hold closure, and refresh closure.lock. - **Refresh closure lock for sh-follow-ups (TP-2498 c2).** - **Attest ci-wait's new import closure for #3261.** - **Merge remote-tracking branch 'origin/agent-chat/tpo-tp2498c2' into agent-chat/tpo-tp2498c3.** - **Carry follow-ups on adopted-seat and panel member verdicts (TP-2498 c3).** - **Add sidecar mutations and lint fixes for the c3 tests (TP-2498 c3).** - **File the settled verdict's follow-ups inside takeAwaited (TP-2498 c3).** The panel's correctness member took its verdict through takeAwaited, which skipped the follow-up filing only takeVerdict did, so its Follow-ups block was dropped in every panel run. Filing now happens in takeAwaited's non-held return, covering both callers. - **Wrap settleAwaited's signature under the line-length limit (TP-2498 c3).** - **Add the c3 changeset for member follow-ups (TP-2498 c3).** Refs: TP-2498, Federal Reserve Best Shows Bank Securely With Just Addressing Read - **Show the pr-visual pairs and a packet line in the weekly visual round (TP-4761 C3) (#3266).** ## Summary Stacked on #3264 (C1). `shepherd visual-week --images <dir>` now writes each batched PR's pr-visual before and after pairs under `<dir>/pr-<n>/` and adds one packet section per PR with the line `pr-visual: n shots, k changed, m missing (unattested producer output; not used for the tier)`. - A PR with no artifact, an artifact for another PR or head, a shot missing a side, or an unreadable zip gets a stated reason and no images, never an after-only set. - Files are written under names Shepherd chooses, never the artifact's; the written manifest is the one `pairVisuals` already reads. - Evidence informs only. `visual-week.ts` defines its own `RoundVisuals` type and imports no reader; the C1 isolation test now also lists the new round writer. - Without `--images` the command stays read-only and output is unchanged. ## TP-1698 done_when Met: pairs labelled before and after per story and width, written into `<round-dir>/pr-<n>/` and pairable by `pairVisuals`; a missing artifact or head mismatch yields a stated reason, never an after-only set; tests use a synthetic fixture zip. Differs: it lands in `visual-week` rather than `brief-visuals.ts`, it fetches through the C1 reader (artifact listing at the head plus the run's workflow check) rather than `gh run download`, and the path is `pr-<n>/` not `img/pr-<n>/`. The `shepherd brief --images` docs line in `site/guides/shepherd.md` is not written. ## Concern `visual-week-command.ts` is in the G10 hold closure, so importing the writer adds `pr-visual-evidence.ts`, `pr-visual-round.ts`, `pr-visual-zip.ts` and `visual-week-visuals.ts` to `g10-hold-closure.json` (regenerated, +4 lines). Later edits to them need adversary sign-off. ## Tests New `visual-week-visuals.test.ts` (pairs per PR with an artifact; no artifact says why; after-only shot shows nothing; another head shows nothing). Each of the four sidecar mutations was applied by hand and killed. The shared `parked` fixtures moved to `visual-week.test-helpers.ts`. ## Changes - **Delete the dormant pixel tier 1 from Shepherd's visual tier (TP-4761 C2).** A rendered class is always tier 2, and a stored record with basis no-pixel-diff fails the record schema, so it gates as tier 2. - **Add a changeset for the pixel tier removal (TP-4761 C2).** - **Read the pr-visual artifact as evidence only (TP-4761 C1).** - **Add a changeset for the pr-visual evidence read (TP-4761 C1).** - **Drop exports nothing outside the evidence files uses (TP-4761 C1).** - **Trim the pr-visual evidence fixtures (TP-4761 C1).** - **Carry pr-visual pairs and a packet line in the weekly visual round (TP-4761 C3).** - **Add the pr-visual round writer, its sidecar and a changeset (TP-4761 C3).** - **Merge remote-tracking branch 'refs/remotes/origin/agent-chat/tpo-tp4761-c1' into agent-chat/tpo-tp4761-c3.** - **Expose --images on the shepherd visual-week verb (TP-4761 C3).** The registry command took an images directory but the CLI verb never declared the flag, so commander refused it. The verb now resolves a relative --images against its own cwd, and the command accepts only an absolute path so an MCP caller cannot write relative to the hub's cwd. Refs: TP-4761, #3266 - **Stop a thaw-waiting run ordering peers or holding the deploy (TP-4778) (#3267).** ## Summary ## What A Shepherd run that sits in `merge-settle` waiting at its head on a gate only a freeze or a deploy ends (freeze-wait.ts `thaw`) could hold everyone else up: - **Merge order.** `orderDriving` still counted it as driving, so its reservation kept overlapping peers waiting at their merge until the TTL. - **Deploy.** `busyRuns` counted it as busy. On `attest-deploy-skew` the run waits for a deploy, and the deploy pacer and restart drain were holding that same deploy on busy runs. The two waited on each other until the pacer's cap ran out. ## Change - New `shepherd/thaw-wait.ts`: `thawWait(run)` returns the run's newest recorded `merge-policy` decision when all of these hold: - it is a gate, - it was taken at the head of the newest `ci-wait` read, - `settleKind` classes it `thaw`, - the run's current step and every active step are `merge-settle`. It reads only recorded step fields (rule table/rowId, headSha), with no new regex. - `orderDriving` skips a run in a thaw wait. The run orders again as soon as a later decision or a new CI head ends the wait. - `busyRuns` skips a run whose thaw wait is `attest-deploy-skew`. Freeze-only waits stay busy, since no deploy ends a freeze. - Fail closed: if any non-settle step is active (a merge or update-branch write), the run stays driving and busy. - `thaw-wait.ts` is added to the G10 hold closure list. No GitHub write is added. This replaces the original "re-post approval" scope, which factory-coord re-scoped: the recorded run showed the merge tree as clean through ruleset bypass, so the review block was never the blocker. ## Tests `thaw-wait.test.ts` replays the deadlock: run R is gated on deploy skew while it holds an overlapping reservation that peer S waits behind, and the deploy waits on R's busy count. It also covers a freeze-only wait, a bounded settle wait, the wait ending, a moved CI head, and an active write step. The sidecar has 5 mutants, each checked locally to be killed. The held-reserver sidecar's `find` is updated for the new term. Checks run locally: build, typecheck, lint, dag:check, docs:build, `verify:changed`, and the full vitest suite. The only full-suite failure was the G10 closure snapshot; after adding the module to the list, the G10 tests pass. ## Changes - **Add failing test for the deploy-skew wait deadlock (TP-4778).** - **Stop a thaw-waiting run ordering peers or holding the deploy (TP-4778).** A run settling at its head on a freeze or on attest-deploy-skew cannot merge until that wait ends, yet its merge-order reservation kept peers waiting, and its busy count held the very deploy that would end a skew wait. orderDriving now skips a run whose recorded decision at its newest CI head is a thaw gate while it sits only in merge-settle, and busyRuns skips such a run on attest-deploy-skew. Any other active step keeps it driving and busy, so no run mid-write is left out. - **Type the thaw-wait test's active steps without an assertion.** - **List thaw-wait.ts in the G10 hold closure.** - **Merge remote-tracking branch 'refs/remotes/origin/main' into fix/tp-4778-retarget-review-required.** Refs: TP-4778, #3267 - **Speed up the R60 carry-import rule (TP-4779) (#3268).** ## Summary The R60 "holds in this repo" test hit vitest's 30 s limit under CI load (TP-4779). Profile: 3.3 s of a 4.3 s run was the glob matcher's `step` (NFA per glob per path), run on every source file and again on every import target. Compiling was already once. Fix: memoise the matcher per path, and match a file's own path only when it has a relative import that hits a test or carry path. Behaviour is unchanged. No timeout change. Timing (local, rule alone on main): 4.2-4.6 s before, 1.2 s after. The `structure.test.mjs` file runs in 2.2 s. Tests: a call-count test through an injected `compileGlobs` seam (one compile, no matching of import-free files). Sidecar mutations: the existing one is re-anchored, one added; both applied by hand and killed. ## Changes - **Match fix-proof globs lazily and memoised in the R60 rule (TP-4779).** Refs: TP-4779, #3268 Refs: TP-592, #3255
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@HJewkes