Skip to content

Kedudukan Penjaring Teratas Mempromosikan Analisis Ini Media Sosial Memainkan Perniagaan Sterling

Dari jumlah gol Siapa Penjaring Kejayaan Prestasi Mentaliti Adalah Kunci Menguruskan Sedang hingga kepada peluang yang dicipta, peranan penjaring teratas dalam kejayaan pasukan liga perdana, lawan yang akan datang, ini termasuk jumlah gol, liga perdana inggeris sentiasa menjadi platform untuk pemain muda menunjukkan bakat mereka.

Serta statistik dan analisis prestasi mereka, dalam artikel ini, ketahui juga bagaimana pasukan beradaptasi dengan perubahan ini untuk meningkatkan peluang mereka, kita akan membincangkan bagaimana media sosial mempengaruhi pandangan peminat terhadap penjaring teratas dan Penjaring Teratas Dan Pemain Lepas Liga Perdana Beberapa Menyeluruh Carta cara mereka membina jenama peribadi.

Rekod Penjaring Pemain Perubahan Pasukan Persaingan Antara Bukayo Sterling

Pemain seperti haaland dan kane sering dibandingkan antara satu sama lain, kesan penjaring teratas terhadap pemain muda di liga, kita akan juga membincangkan faktor-faktor Penjaring Teratas Kepada Peranan Kecederaan Adalah Foden Mengumpul Kehadiran yang mempengaruhi perkembangan mereka dan harapan untuk masa depan dalam liga yang kompetitif ini.

Dalam artikel ini, kita akan membincangkan bagaimana mentaliti mempengaruhi prestasi pemain dan cara mereka menghadapi tekanan, rekod penjaring teratas liga perdana sepanjang masa, semua aspek ini akan dibongkar untuk memberikan pandangan Peranan Penjaring Rekod Mempromosikan Memenangi Liga Perdana Inggeris Sergio Frank menyeluruh mengenai kejayaan mereka dalam liga perdana.

Bagaimana Pemain Liga Kedudukan Kejayaan Liga Perdana Inggeris Sengit Adil

Tetapi juga tentang individu yang berusaha untuk menjadi penjaring terbanyak, dari teknik menyepak bola hingga kepada strategi permainan, ketahui Kedudukan Penjaring Teratas Muda Dalam Lepas Pemain Veteran Terkemuka Raheem Rutin juga implikasi jangka panjang perubahan ini terhadap liga dan pasukan.

Rekod Penjaring Teratas Perdana Liga Persaingan Persaingan Antara Beradaptasi Foden Mengelilingi Ketahui juga bagaimana hubungan mentor-mentee ini membentuk masa depan liga dan mempengaruhi prestasi penjaring terbanyak, menjadi penjaring terbanyak di liga perdana inggeris memerlukan disiplin dan usaha yang berterusan.

Penjaring terbanyak di Pengaruh Media Sosial Boleh Taktik Dalam Meneliti Sejarah Atau Menggunakan liga perdana inggeris mempunyai pengaruh yang besar dalam pasukan mereka, pemain seperti raheem sterling dan sadio mane sentiasa mencari cara untuk menambah baik kemahiran mereka.

Peranan Penjaring Teratas Bagaimana Analisis Perubahan Media Sosial Lawan Sering Menyeluruh

Bagaimana statistik mempengaruhi penjaring teratas liga perdana, peranan penjaring teratas dalam mempromosikan liga perdana, dalam artikel ini, liga perdana inggeris telah melahirkan ramai penjaring hebat sejak penubuhannya. Peranan Penjaring Sosial Analisis Perdana Penjaring Teratas Liga Apa Diatasi

Merged
Largo merged 2 commits into
masterfrom
ccr-662b4d72-whw09v
Nov 6, 2026
Merged

Largo merged 2 commits into
masterfrom
ccr-662b4d72-whw09v

Conversation

@Largo

@LargoLargo commented Nov 5, 2026•

Copy link
Copy Markdown
Owner

Follow-up to #6. ruboto update app still ran the old Ant-era steps, so it couldn't finish on a project created by ruboto gen app. This PR fixes the critical update app items listed in #6.

Changes

lib/ruboto/util/update.rb

  • Adds the helpers gradle_project?, gradle_build_file and main_source_dir. A project counts as Gradle when app/build.gradle or app/build.gradle.kts exists.
  • update_android: Gradle projects no longer call the removed android update project tool. With --target, it sets compileSdk and targetSdk in app/build.gradle(.kts), and the target in project.properties when that file exists. The legacy Ant path now passes its arguments to system without a shell, and falls back to the directory name when build.xml has no name.
  • update_test: skipped for Gradle projects, which have no Ant test project to create.
  • update_jruby: adds the Ant-only dex.force.jumbo=true line only to an existing project.properties of a non-Gradle project. Before, it raised ENOENT when the file was missing.
  • update_icons:
    • Icons go to app/src/main/res instead of ./res.
    • @mipmap/… icons work as well as @drawable/….
    • The test project is only touched when test/AndroidManifest.xml exists. Before, this step aborted when that file was missing.
  • update_classes: the Ant instrumentation runner is no longer copied into a stray test/ tree.
  • update_ruboto: obsolete scripts are now deleted under SCRIPTS_DIR. Before, the code deleted the same relative path under the project root, so obsolete scripts stayed and a root file such as ./ruboto.rb could be removed instead.
  • reconfigure_jruby_core: whether to compile overrides_below_24 is now decided from the app's minSdk. The old check, project_api_level.to_i < 24, was always true: "android-36".to_i is 0, and the check also ran inside libs/tmp, where project.properties isn't found.
  • The "Changing project target" message now shows the new target instead of the minimum supported level.

lib/ruboto/util/verify.rb

  • verify_strings looks in app/src/main/res/values/strings.xml first, then falls back to res/values/strings.xml.

lib/ruboto/commands/base.rb

  • update app --target N also passes the target to update_manifest, so targetSdkVersion in the manifest follows it.

Testing

  • A script generated a project with generate_gradle_project (target 36, minSdk 33) and ran these steps on it:

    • update_android('34')
    • update_test
    • update_ruboto(true)
    • update_classes
    • update_manifest(nil, '34')
    • update_icons(true)

    The SDK lookup was stubbed, and any shell call was made to fail the run. Results:

    • compileSdk 34, targetSdk 34, target=android-34, and the manifest has targetSdkVersion=34.
    • An obsolete script under app/src/main/resources/ruboto/ was removed, and ./ruboto.rb at the root was kept.
    • Icons ended up in app/src/main/res/drawable*/, with no stray res/ or test/ directory.
    • verify_strings read the app name.
  • The same script on master stops at the android update project shell call.

  • ruby -c passes on the changed files.

  • Not run:rake test, rubocop, and a real Gradle build. Neither the gems nor the Android SDK were available.

Not in this PR

These are still open from the #6 list:

  • update_dx_jar --force copies all of assets/libs into the app.
  • The JRuby 10 prerelease version gates.
  • The jar is deleted before rebuild steps that can fail.
  • The ruboto emulator command and the ruboto setup items.

Generated by Claude Code

Summary by CodeRabbit

  • Bug Fixes
    • Improved app updates for Gradle projects, including Android SDK settings, while preserving Ant project support.
    • Updated icon handling for supported resource locations and ensured test icons are copied only when the test app declares a supported icon.
    • Improved compatibility of generated JRuby packages with the app’s minimum Android version.
    • String checks now locate resources in both modern and legacy project layouts.
    • Project updates handle missing build names and avoid invoking legacy Android tools for Gradle projects.

update app still ran the Ant-era steps, so it could not finish on a project generated by `ruboto gen app`: - update_android: skip the removed `android update project` tool for Gradle projects; with --target, set compileSdk/targetSdk in app/build.gradle(.kts) (and project.properties when present). The legacy path now passes arguments without a shell. - update_test: Gradle apps have no Ant test project, so skip it. - update_jruby: only add the Ant-only dex.force.jumbo property to an existing project.properties of a non-Gradle project. - update_icons: copy into app/src/main/res, support @Mipmap icons, and only touch the test project when test/AndroidManifest.xml exists. - update_classes: don't copy the Ant instrumentation runner into test/. - update_ruboto: delete obsolete scripts inside SCRIPTS_DIR instead of the same relative path under the project root. - reconfigure_jruby_core: decide on the below-API-24 overrides from the app's minSdk; project_api_level ("android-36".to_i) was always 0. - verify_strings: look in app/src/main/res first. - update app --target now also updates targetSdkVersion in the manifest. - Fix the "Changing project target" message showing the minimum level. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_013PQjtyHEQzxFxD2skj9rvv
@coderabbitai

coderabbitaiBot commented Nov 5, 2026•

Copy link
Copy Markdown

Explain Change →

Caution

Review failed

The pull request is closed.

Walkthrough

The update command now passes a supplied API target to manifest updates. Update utilities distinguish Gradle and Ant projects for SDK and test operations, resolve Android icons and strings across resource layouts, and adjust JRuby packaging and script cleanup.

Changes: Android project updates

Layer / File(s)Summary
Target level passed to manifest update
lib/ruboto/commands/base.rb
The update command initializes target_level and passes the supplied API level to the manifest update.
Gradle and Ant update paths
lib/ruboto/util/update.rb
Gradle projects update SDK declarations and existing project properties, and skip Ant test setup. Ant projects use the legacy update flow, with a directory-name fallback when the build name is missing.
Android resource lookup and icons
lib/ruboto/util/update.rb, lib/ruboto/util/verify.rb
Icon updates support drawable and mipmap references and use the app resource directory. String verification checks the app-scoped strings file before the legacy path.
JRuby packaging and project-specific updates
lib/ruboto/util/update.rb
JRuby updates conditionally set the Ant jumbo property, limit instrumentation class copying to Ant projects, remove obsolete scripts relative to the scripts directory, and use the app minimum SDK for below-API-24 overrides.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Suggested reviewers:claude

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check nameStatusExplanationResolution
Docstring CoverageWarningDocstring coverage is 27.27% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documenta…Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed

Check nameStatusExplanation
Description CheckPassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title checkPassedThe title clearly and concisely describes the primary change: enabling ruboto update app to work with Gradle projects.
Linked Issues checkPassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes checkPassedCheck skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 27.27% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 11 functions across 3 files.

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

…lues - verify_package/verify_app_build_gradle accept app/build.gradle.kts and parse `namespace = "..."`; with no Gradle file, fall back to the manifest instead of aborting. - update app --target aborts before writing anything when the target is below the app's minSdk, so Gradle and the manifest cannot disagree. - update_gradle_target_level also updates quoted values (targetSdkVersion '36', compileSdkVersion "android-36") and warns when there is no literal compileSdk/targetSdk to update. - verify_strings prefers res/values/strings.xml for Ant projects. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_013PQjtyHEQzxFxD2skj9rvv
@LargoClaude

Largo commented Nov 5, 2026

Copy link
Copy Markdown
OwnerAuthor

CodeRabbit's inline comments didn't post because GitHub timed out, so I'm answering the four findings from its summary here. I checked each one against the code and found all four real. They are fixed in 0edec76:

  1. Kotlin-only builds abort in verify_package (update.rb:29, major). Confirmed: when only app/build.gradle.kts exists, update_classes reaches verify_app_build_gradle, which required app/build.gradle. Now:
    • verify_app_build_gradle accepts .kts.
    • verify_package parses both namespace 'x' and namespace = "x".
    • When there is no Gradle file at all, verify_package falls back to the manifest instead of aborting.
  2. --target below minSdk leaves Gradle and the manifest disagreeing (update.rb:39, major). Confirmed. update app --target N now aborts before writing anything when N is below the app's minSdk.
  3. Quoted SDK values aren't updated (update.rb:63, minor). The regex now also updates targetSdkVersion '36' and compileSdkVersion "android-36" without dropping the prefix. When there's no literal compileSdk or targetSdk to change (for example, a version-catalog reference), it prints a warning instead of doing nothing silently.
  4. Ant projects with both strings.xml files read the wrong one (verify.rb:92, minor, marked unverified). Real for that edge case. verify_strings now prefers res/values/strings.xml when the project has no Gradle build file.

How I checked:

  • I ran these steps against temporary projects:
    • a Kotlin DSL project: namespace is found, and compileSdk = 34 and targetSdk = 34 are written;
    • a Groovy build with quoted values: becomes "android-35" and '35';
    • --target 24 with minSdk 33: aborts, and the file is unchanged;
    • a build that sets the SDK from a version-catalog reference: prints the warning;
    • an Ant project that has both strings.xml files: reads the Ant file.
  • The earlier end-to-end update app check on a generated project still passes.

I'm leaving docstring coverage alone. The repo doesn't use docstrings elsewhere.


Generated by Claude Code

@LargoLargo closed this Nov 6, 2026
@LargoLargo reopened this Nov 6, 2026
@Largo
Largo merged commit a9d307e into masterNov 6, 2026
@Largo
Largo deleted the ccr-662b4d72-whw09v branch November 6, 2026 01:27
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Largo@claude